Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Linting on Pre-Push #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ericpassmore
Copy link

@ericpassmore ericpassmore commented Aug 4, 2023

Fixes #21 Changes to automate error checking and improved code formmating.

Added a git hook, that fires before pushing to a remote. This hook runs the following checks

  • check for uncommitted work, need to stash changes or commit before pushing
  • yarn install --check-files make sure you have the right packages installed
  • prettier . --write . auto-reformats code to match prettier rules
  • eslint static error checks

All fixes have been tested and applied to the branch gh-21-linting-test. Take a look at that branch if you would like to review the end result.

Note you can always skip the check by adding the --no-verify option at the end of you push. Example git push origin my-feature-branch --no-verify

@ericpassmore ericpassmore requested review from nsjames, oschwaldp-oci and taokayan and removed request for nsjames August 4, 2023 05:41
.husky/pre-push Show resolved Hide resolved
.husky/pre-push Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added ESLint and Prettier
2 participants